Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to disable datasource recovery #47118

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Add the ability to disable datasource recovery #47118

merged 1 commit into from
Apr 10, 2025
+101 −0

Conversation

mmusgrov
Copy link
Contributor

@mmusgrov mmusgrov commented Apr 1, 2025 •
edited by geoand
Loading

Disable automatic recovery for XA capable DataSources

@mmusgrov mmusgrov force-pushed the 47117-recover branch 2 times, most recently from 5d11231 to bd82a42 Compare April 2, 2025 08:34
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Apr 2, 2025
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@gsmet gsmet changed the title 47117 config property to disable datasource recovery Add the ability to disable datasource recovery Apr 2, 2025
@gsmet gsmet requested a review from yrodiere April 2, 2025 09:27
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gastaldi
gastaldi approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense

@mmusgrov
Copy link
Contributor Author

mmusgrov commented Apr 8, 2025

Thanks @gastaldi and @yrodiere Would it be possible to merge it so that we can tell the stakeholders so that they can verify that it resolves their issue.

yrodiere
yrodiere reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Sorry for the delay, I was traveling last week.

The implementation/test look fine. I have my doubts about the documentation (see below), but feel free to pick what makes sense and merge.

Cheers.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 9, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b89838c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 9, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b89838c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet requested a review from yrodiere April 10, 2025 14:46
yrodiere
yrodiere approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yrodiere yrodiere merged commit ec80b9b into quarkusio:main Apr 10, 2025
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 10, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/agroal area/docstyle issues related for manual docstyle review area/documentation kind/enhancement New feature or request
Projects
None yet
Milestone
3.22 - main
Development

Successfully merging this pull request may close these issues.

Disable automatic recovery for XA capable DataSources
3 participants
@mmusgrov @gastaldi @yrodiere